Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-33692: php improvements #922

Merged
merged 9 commits into from
Oct 18, 2023
Merged

DOCSP-33692: php improvements #922

merged 9 commits into from
Oct 18, 2023

Conversation

rustagir
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33692
Staging - https://preview-mongodbrustagir.gatsbyjs.io/drivers/DOCSP-33692-php-arq-updates/php/#driver-architecture

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

jordan-smith721
jordan-smith721 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question and a couple minor suggestions

source/php.txt Outdated Show resolved Hide resolved
source/php.txt Outdated Show resolved Hide resolved
@bisht2050 bisht2050 self-requested a review October 17, 2023 20:14
alcaeus
alcaeus approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion.

source/php.txt Outdated Show resolved Hide resolved
@rustagir rustagir merged commit 36f9cc7 into mongodb:master Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

@jordan-smith721 jordan-smith721 jordan-smith721 approved these changes

@bisht2050 bisht2050 bisht2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rustagir @alcaeus @jordan-smith721 @bisht2050